test(coverage/readiness): drive readiness to >=95% (was 86.5%)#28
Merged
Conversation
Adds defensive tests for previously-uncovered paths in common/readiness: - PingDB: nil db_not_configured + ping failure via registered fake driver - HTTPHeadCheck: 408 / 429 / generic 4xx mapHTTPStatus arms, bad-URL request_build_failed path, default method=GET fallback - GRPCHealth: nil checker grpc_not_configured guard - scrubNetError: dns / tls / connection_refused / timeout / deadline / short + long generic branches (exercised via GRPCHealth wrapper) - formatTimeout: exposed via export_test.go FormatTimeoutForTest Total line coverage: 86.5% -> 98.6%. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common/readinessline coverage from 86.5% → 98.6%.readiness/files.Test plan
go test ./readiness -coverprofile=/tmp/r-cov.outpasses;go tool cover -funcshows 98.6% totalgo test ./...green across all common packagesgo vet ./readinesscleanCo-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com